Skip to content

Remove GET request support from Saml2AuthenticationTokenConverter #17108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

Remove GET request support from Saml2AuthenticationTokenConverter #17108

merged 2 commits into from
Jun 3, 2025

Conversation

@ngocnhan-tran1996
Copy link
Contributor

@ngocnhan-tran1996 ngocnhan-tran1996 commented May 14, 2025 •
edited
Loading

I think we can define Boolean shouldInflate and method decode will be added

if (this.shouldInflate == null) {
	this.shouldInflate = HttpMethod.GET.matches(request.getMethod());
}

If not, this will break Saml2LoginBeanDefinitionParserTests and Saml2AuthenticationTokenConverterTests

Saml2LoginBeanDefinitionParserTests > authenticateWhenCustomAuthnRequestRepositoryThenUses() FAILED
    org.mockito.exceptions.verification.WantedButNotInvoked at Saml2LoginBeanDefinitionParserTests.java:323

Saml2LoginBeanDefinitionParserTests > authenticateWhenAuthenticationResponseValidThenAuthenticate() FAILED
    java.lang.AssertionError at Saml2LoginBeanDefinitionParserTests.java:213

Saml2LoginBeanDefinitionParserTests > authenticateWhenAuthenticationResponseValidThenAuthenticationSuccessEventPublished() FAILED
    java.lang.AssertionError at Saml2LoginBeanDefinitionParserTests.java:245

Saml2LoginBeanDefinitionParserTests > authenticateWhenCustomSecurityContextHolderStrategyThenUses() FAILED
    java.lang.AssertionError at Saml2LoginBeanDefinitionParserTests.java:228

Saml2LoginBeanDefinitionParserTests > authenticateWhenCustomAuthenticationManagerThenUses() FAILED
    java.lang.AssertionError at Saml2LoginBeanDefinitionParserTests.java:280

Issue: gh-17099

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 14, 2025
@ngocnhan-tran1996 ngocnhan-tran1996 force-pushed the gh-17099 branch 2 times, most recently from eaa03b3 to e6186a1 Compare May 14, 2025 15:57
jzheaux
jzheaux requested changes May 15, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ngocnhan-tran1996! I've left some feedback inline.

@jzheaux jzheaux self-assigned this May 20, 2025
@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels May 23, 2025
@jzheaux jzheaux added this to the 7.0.x milestone May 23, 2025
@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label May 23, 2025
@ngocnhan-tran1996 ngocnhan-tran1996 force-pushed the gh-17099 branch 3 times, most recently from 7b90e07 to 6e793e8 Compare May 25, 2025 06:00
@jzheaux jzheaux mentioned this pull request Jun 2, 2025
Closed
2 tasks
@ngocnhan-tran1996 ngocnhan-tran1996 requested a review from jzheaux June 3, 2025 16:36
@jzheaux jzheaux removed the status: waiting-for-feedback We need additional information before we can continue label Jun 3, 2025
@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 Jun 3, 2025
@jzheaux jzheaux merged commit 4ed131f into spring-projects:main Jun 3, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jun 3, 2025

Thanks, @ngocnhan-tran1996! This is now merged into main. Also in f73f253 I updated related authentication converter implementations. I also added migration docs.

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the gh-17099 branch June 4, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels

in: saml2 An issue in SAML2 modules type: enhancement A general enhancement

Projects

None yet

Milestone

7.0.0-M1

Development

Successfully merging this pull request may close these issues.

3 participants

@ngocnhan-tran1996 @jzheaux @spring-projects-issues